Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robots.txt with multilang/multishop #12106

Merged
merged 4 commits into from Jan 19, 2019
Merged

Robots.txt with multilang/multishop #12106

merged 4 commits into from Jan 19, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jan 10, 2019 •
edited by eternoendless

Questions Answers
Branch? 1.7.5.x
Description? Add the correct path to Disallow directories when using a multishop or a multilang instance.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12032
How to test? Create a multilang instance and make sure you have Disallow with all your languages. Same with a multishop instance and physical path.

This change is Reviewable

Robots.txt with multilang/multishop
0ee2dbc 
Add the correct path to Disallow directories when using a multishop or
a multilang instance.
@PierreRambaud PierreRambaud added this to the 1.7.5.1 milestone Jan 10, 2019
@prestonBot prestonBot added 1.7.5.x Branch Bug Type: Bug labels Jan 10, 2019
Quetzacoalt91
Quetzacoalt91 reviewed Jan 15, 2019
View reviewed changes
classes/Tools.php Outdated Show resolved Hide resolved
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Jan 15, 2019
@ntiepresta ntiepresta self-assigned this Jan 18, 2019
@mbadrani mbadrani assigned mbadrani and unassigned ntiepresta Jan 18, 2019
@mbadrani mbadrani added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 18, 2019
@matks matks merged commit e5b7448 into PrestaShop:1.7.5.x Jan 19, 2019
@matks
Copy link
Contributor

matks commented Jan 19, 2019

Thanks @PierreRambaud

@PierreRambaud PierreRambaud deleted the fix/12032 branch January 19, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasReker MathiasReker MathiasReker left review comments

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@mbadrani mbadrani

Labels
1.7.5.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.5.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@PierreRambaud @matks @Quetzacoalt91 @MathiasReker @prestonBot @mbadrani @ntiepresta